> On Feb. 13, 2015, 7:01 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/OffsetManager.scala, line 215 > > <https://reviews.apache.org/r/29912/diff/3/?file=862699#file862699line215> > > > > Minor comment. I think this may be better to pass in to the > > OffsetManager. > > > > We should even use it in loadOffsets to discard offsets that are from > > topics that have been deleted. We can do that in a separate jira - I don't > > think our handling for clearing out offsets on a delete topic is done yet - > > Onur Karaman did it for ZK based offsets but we need a separate jira to > > delete Kafka-based offsets. > > Sriharsha Chintalapani wrote: > Thanks for the review. Since offsetmanager initialized in KafkaServer and > metadataCache in KafkaApis , in the latest patch I added setMetadataCache in > OffsetManager and calling it in KafkaApis. Please take a look > > Joel Koshy wrote: > In that case I think it is just better to create the cache outside (in > KafkaServer and pass it in to KafkaApis). The metadataCache is useful enough > to be used in other places (other than just KafkaApis).
Updated the patch as per your suggestion. Please take a look. thanks. - Sriharsha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29912/#review72413 ----------------------------------------------------------- On Feb. 18, 2015, 9:13 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29912/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 9:13 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1852 > https://issues.apache.org/jira/browse/KAFKA-1852 > > > Repository: kafka > > > Description > ------- > > KAFKA-1852. OffsetCommitRequest can commit offset on unknown topic. Added > contains method to MetadataCache. > > > KAFKA-1852. OffsetCommitRequest can commit offset on unknown topic. > > > KAFKA-1852. OffsetCommitRequest can commit offset on unknown topic. > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaApis.scala > 703886a1d48e6d2271da67f8b89514a6950278dd > core/src/main/scala/kafka/server/KafkaServer.scala > 7e5ddcb9be8fcef3df6ebc82a13ef44ef95f73ae > core/src/main/scala/kafka/server/MetadataCache.scala > 4c70aa7e0157b85de5e24736ebf487239c4571d0 > core/src/main/scala/kafka/server/OffsetManager.scala > 83d52643028c5628057dc0aa29819becfda61fdb > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala > 5b93239cdc26b5be7696f4e7863adb9fbe5f0ed5 > > Diff: https://reviews.apache.org/r/29912/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
