----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29912/#review74569 -----------------------------------------------------------
Ship it! Minor locking issue noted below. I can take care of that. This obviously does not cover the case of committing offsets to a topic that is currently being deleted. I think that can be done in a separate jira. Can you file one? core/src/main/scala/kafka/server/KafkaServer.scala <https://reviews.apache.org/r/29912/#comment121175> This can just be a val core/src/main/scala/kafka/server/MetadataCache.scala <https://reviews.apache.org/r/29912/#comment121176> Should probably do this inReadLock - Joel Koshy On Feb. 18, 2015, 9:13 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29912/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 9:13 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1852 > https://issues.apache.org/jira/browse/KAFKA-1852 > > > Repository: kafka > > > Description > ------- > > KAFKA-1852. OffsetCommitRequest can commit offset on unknown topic. Added > contains method to MetadataCache. > > > KAFKA-1852. OffsetCommitRequest can commit offset on unknown topic. > > > KAFKA-1852. OffsetCommitRequest can commit offset on unknown topic. > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaApis.scala > 703886a1d48e6d2271da67f8b89514a6950278dd > core/src/main/scala/kafka/server/KafkaServer.scala > 7e5ddcb9be8fcef3df6ebc82a13ef44ef95f73ae > core/src/main/scala/kafka/server/MetadataCache.scala > 4c70aa7e0157b85de5e24736ebf487239c4571d0 > core/src/main/scala/kafka/server/OffsetManager.scala > 83d52643028c5628057dc0aa29819becfda61fdb > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala > 5b93239cdc26b5be7696f4e7863adb9fbe5f0ed5 > > Diff: https://reviews.apache.org/r/29912/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
