----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/#review74160 -----------------------------------------------------------
core/src/main/scala/kafka/server/AbstractFetcherThread.scala <https://reviews.apache.org/r/31366/#comment120683> Using the foreach method on partitionMap.get(topicAndPartition) would accomplish the same thing (lines 114-116, and 164) without the need for pattern matching. core/src/main/scala/kafka/server/AbstractFetcherThread.scala <https://reviews.apache.org/r/31366/#comment120684> Again, foreach would be more idomatic, or take advantage of already being in a for loop. - Eric Olander On Feb. 24, 2015, 6:02 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31366/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 6:02 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1461 > https://issues.apache.org/jira/browse/KAFKA-1461 > > > Repository: kafka > > > Description > ------- > > KAFKA-1461. Replica fetcher thread does not implement any back-off behavior. > > > Diffs > ----- > > core/src/main/scala/kafka/server/AbstractFetcherManager.scala > 20c00cb8cc2351950edbc8cb1752905a0c26e79f > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > 8c281d4668f92eff95a4a5df3c03c4b5b20e7095 > core/src/main/scala/kafka/server/KafkaConfig.scala > 14bf3216bae030331bdf76b3266ed0e73526c3de > core/src/main/scala/kafka/server/OffsetAndDelay.scala PRE-CREATION > core/src/main/scala/kafka/server/ReplicaFetcherThread.scala > 6879e730282185bda3d6bc3659cb15af0672cecf > core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala > da4bafc1e2a94a436efe395aab1888fc21e55748 > > Diff: https://reviews.apache.org/r/31366/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
