----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/#review78120 -----------------------------------------------------------
Couple of comments. Thanks! core/src/main/scala/kafka/server/AbstractFetcherThread.scala <https://reviews.apache.org/r/31366/#comment126590> Can you add a comment explaning why this flag is used? It only seems to be used in doWork() so perhaps it shouldn't be a member variable? core/src/main/scala/kafka/server/AbstractFetcherThread.scala <https://reviews.apache.org/r/31366/#comment126589> I guess you don't need to set this to false if it already is. core/src/main/scala/kafka/server/AbstractFetcherThread.scala <https://reviews.apache.org/r/31366/#comment126594> Perhaps a trace log here before awaiting? core/src/main/scala/kafka/server/AbstractFetcherThread.scala <https://reviews.apache.org/r/31366/#comment126602> Can you add some documentation for this class? - Aditya Auradkar On March 27, 2015, 10:31 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31366/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 10:31 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1461 > https://issues.apache.org/jira/browse/KAFKA-1461 > > > Repository: kafka > > > Description > ------- > > KAFKA-1461. Replica fetcher thread does not implement any back-off behavior. > > > Diffs > ----- > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > 5d5cf5897cc37b3595f14bfe9d7cde43456bcc4b > core/src/main/scala/kafka/server/ReplicaFetcherThread.scala > 96faa7b4ed7c9ba8a3f6f9f114bd94e19b3a7ac0 > > Diff: https://reviews.apache.org/r/31366/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
