Yes. It was addressed in the latest patch set. A private method called toPositive was added so that the partition selection is preserved cross this and previous versions.
Thanks Sent from my iPhone > On Mar 4, 2015, at 12:49 AM, Guozhang Wang <wangg...@gmail.com> wrote: > > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31566/ > > Tong, could you address Jun's last comments before committing? > > - Guozhang Wang > > > On February 27th, 2015, 11:16 p.m. UTC, Tong Li wrote: > > Review request for kafka. > By Tong Li. > Updated Feb. 27, 2015, 11:16 p.m. > > Bugs: KAFKA-1988 > Repository: kafka > Description > > KAFKA-1988 org.apache.kafka.common.utils.Utils.abs method returns wrong value > for negative numbers > Diffs > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Partitioner.java > (dfb936d8f0d5842ee5c7a7f1584c5ed7463c4cf8) > clients/src/main/java/org/apache/kafka/common/utils/Utils.java > (69530c187cd1c41b8173b61de6f982aafe65c9fe) > clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java > (4c2ea34815b63174732d58b699e1a0a9e6ec3b6f) > View Diff
