Guozhang,
Yes, I have rebased and updated the patch set to resolve the couple
comments for code comments. Also removed the trailing spaces (which always
annoying. :-) ), Please see the new patch set here. Sorry for the delay.
https://reviews.apache.org/r/31566/
Thanks.
Tong Li
OpenStack & Kafka Community Development
Building 501/B205
liton...@us.ibm.com
"Guozhang Wang" <nore...@reviews.apache.org> wrote on 03/03/2015 11:48:36
AM:
> From: "Guozhang Wang" <wangg...@gmail.com>
> To: "kafka" <dev@kafka.apache.org>, "Guozhang Wang"
> <wangg...@gmail.com>, Tong Li/Raleigh/IBM@IBMUS
> Date: 03/03/2015 11:49 AM
> Subject: Re: Review Request 31566: Patch for KAFKA-1988
> Sent by: "Guozhang Wang" <nore...@reviews.apache.org>
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31566/#review74973
> -----------------------------------------------------------
>
>
> Tong, could you address Jun's last comments before committing?
>
> - Guozhang Wang
>
>
> On Feb. 27, 2015, 11:16 p.m., Tong Li wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/31566/
> > -----------------------------------------------------------
> >
> > (Updated Feb. 27, 2015, 11:16 p.m.)
> >
> >
> > Review request for kafka.
> >
> >
> > Bugs: KAFKA-1988
> > https://issues.apache.org/jira/browse/KAFKA-1988
> >
> >
> > Repository: kafka
> >
> >
> > Description
> > -------
> >
> > KAFKA-1988 org.apache.kafka.common.utils.Utils.abs method returns
> wrong value for negative numbers
> >
> >
> > Diffs
> > -----
> >
> > clients/src/main/java/org/apache/kafka/clients/producer/
> internals/Partitioner.java dfb936d8f0d5842ee5c7a7f1584c5ed7463c4cf8
> > clients/src/main/java/org/apache/kafka/common/utils/Utils.java
> 69530c187cd1c41b8173b61de6f982aafe65c9fe
> > clients/src/test/java/org/apache/kafka/common/utils/
> UtilsTest.java 4c2ea34815b63174732d58b699e1a0a9e6ec3b6f
> >
> > Diff: https://reviews.apache.org/r/31566/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Tong Li
> >
> >
>
