> On April 27, 2015, 4 a.m., Jiangjie Qin wrote:
> > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala, line 107
> > <https://reviews.apache.org/r/33557/diff/1/?file=941740#file941740line107>
> >
> >     Typo, larger.

Thanks for noticing the bytes-out-rate and the typo. I missed that metric.

Please review my latest update.


- Dong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33557/#review81654
-----------------------------------------------------------


On April 27, 2015, 4:26 a.m., Dong Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33557/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 4:26 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1936
>     https://issues.apache.org/jira/browse/KAFKA-1936
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1936; Track offset commit requests separately from produce requests
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/log/Log.scala 
> 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4 
>   core/src/main/scala/kafka/server/KafkaApis.scala 
> b4004aa3a1456d337199aa1245fb0ae61f6add46 
>   core/src/main/scala/kafka/server/ReplicaManager.scala 
> 59c9bc3ac3a8afc07a6f8c88c5871304db588d17 
>   core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 
> 652208a70f66045b854549d93cbbc2b77c24b10b 
> 
> Diff: https://reviews.apache.org/r/33557/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dong Lin
> 
>

Reply via email to