----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/#review83234 -----------------------------------------------------------
core/src/main/scala/kafka/server/KafkaRequestHandler.scala <https://reviews.apache.org/r/33557/#comment134139> How about markBrokerTopicMeters or updateBrokerTopicStats I think an even clearer approach would be to have explicit methods: ``` messagesIn(n) bytesIn(n) bytesOut(n) bytesRejected(n) ``` and so on. The current code assumes everything is a meter (which it is) but the above may be clearer and makes fewer assumptions about the underlying metric types. It may also eliminate the need for the enumeration. What do you think? - Joel Koshy On May 4, 2015, 10:18 p.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33557/ > ----------------------------------------------------------- > > (Updated May 4, 2015, 10:18 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1936 > https://issues.apache.org/jira/browse/KAFKA-1936 > > > Repository: kafka > > > Description > ------- > > KAFKA-1936; Track offset commit requests separately from producer requests > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4 > core/src/main/scala/kafka/server/KafkaApis.scala > b4004aa3a1456d337199aa1245fb0ae61f6add46 > core/src/main/scala/kafka/server/KafkaRequestHandler.scala > a1558afed20bc651ca442a774920d782890167a5 > core/src/main/scala/kafka/server/ReplicaManager.scala > 59c9bc3ac3a8afc07a6f8c88c5871304db588d17 > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala > 652208a70f66045b854549d93cbbc2b77c24b10b > > Diff: https://reviews.apache.org/r/33557/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
