> On May 12, 2015, 2:45 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/KafkaRequestHandler.scala, line 147 > > <https://reviews.apache.org/r/33557/diff/4-5/?file=949209#file949209line147> > > > > Just a minor naming comment: these `mark*Rate` methods can just be > > called `record*` > > > > For e.g., `recordMessagesIn`
I see. Previously I wanted to be more verbose and name the function based on what is done (e.g. *Rate.mark(..)). Could you look at the updated patch? I have renamed these functions. Thank you. - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/#review83398 ----------------------------------------------------------- On May 12, 2015, 3:02 p.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33557/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 3:02 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1936 > https://issues.apache.org/jira/browse/KAFKA-1936 > > > Repository: kafka > > > Description > ------- > > KAFKA-1936; Track offset commit requests separately from produce requests > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4 > core/src/main/scala/kafka/server/KafkaApis.scala > 417960dd1ab407ebebad8fdb0e97415db3e91a2f > core/src/main/scala/kafka/server/KafkaRequestHandler.scala > a1558afed20bc651ca442a774920d782890167a5 > core/src/main/scala/kafka/server/ReplicaManager.scala > 59c9bc3ac3a8afc07a6f8c88c5871304db588d17 > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala > 528525b719ec916e16f8b3ae3715bec4b5dcc47d > > Diff: https://reviews.apache.org/r/33557/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
