> On July 17, 2015, 4:25 p.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java, > > line 56 > > <https://reviews.apache.org/r/35867/diff/4/?file=1011316#file1011316line56> > > > > "given `prefix` string and further qualifies the associated AppInfo > > mbean with the attribute `id`." > > > > Actually, sorry to bring this up again (we discussed it briefly in the > > first diff), but I think it would be better to register the app info > > explicitly in the consumer/producer/broker and remove this argument. It is > > convenient to have it instantiated as part of JmxReporter, but it is weird > > to have to pass in an `id` that will be used only for the app-info mbean.
done the required changes to explicitly register the app info in the consumer/producer/broker. - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review92078 ----------------------------------------------------------- On Aug. 9, 2015, 9:37 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35867/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2015, 9:37 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1901 > https://issues.apache.org/jira/browse/KAFKA-1901 > > > Repository: kafka > > > Description > ------- > > Addresing Joel's comments > > > Diffs > ----- > > build.gradle 1b67e628c2fca897177c12b6afad9a8700fffd1f > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > ed99e9bdf7c4ea7a6d4555d4488cf8ed0b80641b > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 03b8dd23df63a8d8a117f02eabcce4a2d48c44f7 > clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java > PRE-CREATION > core/src/main/scala/kafka/common/AppInfo.scala > d642ca555f83c41451d4fcaa5c01a1f86eff0a1c > core/src/main/scala/kafka/server/KafkaServer.scala > 84d4730ac634f9a5bf12a656e422fea03ad72da8 > core/src/main/scala/kafka/server/KafkaServerStartable.scala > 1c1b75b4137a8b233b61739018e9cebcc3a34343 > > Diff: https://reviews.apache.org/r/35867/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
