> On Aug. 20, 2015, 2:03 a.m., Joel Koshy wrote: > > build.gradle, line 389 > > <https://reviews.apache.org/r/35867/diff/5/?file=1035356#file1035356line389> > > > > This gives an error in detached mode (i.e., not on any branch).
Updated code to handle detached mode. thanks for the review. - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review95902 ----------------------------------------------------------- On Aug. 20, 2015, 7:08 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35867/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2015, 7:08 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1901 > https://issues.apache.org/jira/browse/KAFKA-1901 > > > Repository: kafka > > > Description > ------- > > Addresing Joel's comments, rebase > > > Diffs > ----- > > build.gradle 17fc223907f6b55f2d730be81ddb8d8e07a2c7ad > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > 3749880b765f74af117d6c44705daf170095a1b7 > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > c4621e22c32c1a1fb23726d7f56004845def96ef > clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java > PRE-CREATION > core/src/main/scala/kafka/common/AppInfo.scala > d642ca555f83c41451d4fcaa5c01a1f86eff0a1c > core/src/main/scala/kafka/server/KafkaServer.scala > 0e7ba3ede78dbc995c404e0387a6be687703836a > core/src/main/scala/kafka/server/KafkaServerStartable.scala > 1c1b75b4137a8b233b61739018e9cebcc3a34343 > > Diff: https://reviews.apache.org/r/35867/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
