[
https://issues.apache.org/jira/browse/KAFKA-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712096#comment-14712096
]
ASF GitHub Bot commented on KAFKA-2461:
---------------------------------------
GitHub user SinghAsDev opened a pull request:
https://github.com/apache/kafka/pull/169
KAFKA-2461: request logger no longer logs extra information in debug mode
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SinghAsDev/kafka KAFKA-2461
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #169
----
commit 6cce97cef5ab52c394a94c8a2062f543ee6d4d81
Author: asingh <asi...@cloudera.com>
Date: 2015-08-25T22:32:56Z
KAFKA-2461: request logger no longer logs extra information in debug mode
----
> request logger no longer logs extra information in debug mode
> -------------------------------------------------------------
>
> Key: KAFKA-2461
> URL: https://issues.apache.org/jira/browse/KAFKA-2461
> Project: Kafka
> Issue Type: Bug
> Reporter: Gwen Shapira
> Assignee: Ashish K Singh
> Fix For: 0.8.3
>
>
> Currently request logging calls are identical for trace and debug:
> {code}
> if(requestLogger.isTraceEnabled)
> requestLogger.trace("Completed request:%s from connection
> %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d"
> .format(requestDesc, connectionId, totalTime,
> requestQueueTime, apiLocalTime, apiRemoteTime, responseQueueTime,
> responseSendTime))
> else if(requestLogger.isDebugEnabled)
> requestLogger.debug("Completed request:%s from connection
> %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d"
> .format(requestDesc, connectionId, totalTime, requestQueueTime,
> apiLocalTime, apiRemoteTime, responseQueueTime, responseSendTime))
> {code}
> I think in the past (3 refactoring steps ago), we used to print more
> information about specific topics and partitions in debug mode.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
