[ 
https://issues.apache.org/jira/browse/KAFKA-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729534#comment-14729534
 ] 

Ashish K Singh commented on KAFKA-2461:
---------------------------------------

[~ijuma] Oops, I got it reversed. That's my bad. However, I feel that info 
actually fits at debug level as well. What do you think? Would you suggest I 
fix it as part of a separate JIRA or same JIRA. Thanks for pointing it out.

> request logger no longer logs extra information in debug mode
> -------------------------------------------------------------
>
>                 Key: KAFKA-2461
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2461
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Gwen Shapira
>            Assignee: Ashish K Singh
>            Priority: Blocker
>             Fix For: 0.8.3
>
>
> Currently request logging calls are identical for trace and debug:
> {code}
> if(requestLogger.isTraceEnabled)
>         requestLogger.trace("Completed request:%s from connection 
> %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d"
>                 .format(requestDesc, connectionId, totalTime, 
> requestQueueTime, apiLocalTime, apiRemoteTime, responseQueueTime, 
> responseSendTime))
>       else if(requestLogger.isDebugEnabled)
>         requestLogger.debug("Completed request:%s from connection 
> %s;totalTime:%d,requestQueueTime:%d,localTime:%d,remoteTime:%d,responseQueueTime:%d,sendTime:%d"
>           .format(requestDesc, connectionId, totalTime, requestQueueTime, 
> apiLocalTime, apiRemoteTime, responseQueueTime, responseSendTime))
> {code}
> I think in the past (3 refactoring steps ago), we used to print more 
> information about specific topics and partitions in debug mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to