[
https://issues.apache.org/jira/browse/KAFKA-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990236#comment-14990236
]
ASF GitHub Bot commented on KAFKA-2742:
---------------------------------------
GitHub user ewencp opened a pull request:
https://github.com/apache/kafka/pull/421
KAFKA-2742: Fix SourceTaskOffsetCommitter to handle removal of commit tasks
when they are already in progress.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ewencp/kafka
wait-on-in-progress-source-offset-commits
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/421.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #421
----
commit 023b3be05978ee714955fdfc04809b7e286aaca1
Author: Ewen Cheslack-Postava <m...@ewencp.org>
Date: 2015-11-03T05:26:39Z
KAFKA-2742: Fix SourceTaskOffsetCommitter to handle removal of commit tasks
when they are already in progress.
----
> SourceTaskOffsetCommitter does not properly remove commit tasks when they are
> already in progress
> -------------------------------------------------------------------------------------------------
>
> Key: KAFKA-2742
> URL: https://issues.apache.org/jira/browse/KAFKA-2742
> Project: Kafka
> Issue Type: Bug
> Components: copycat
> Reporter: Ewen Cheslack-Postava
> Assignee: Ewen Cheslack-Postava
> Fix For: 0.9.0.0
>
>
> The current implementation is relying on ScheduledExecutorService to cancel
> the task, but this doesn't handle in-progress tasks and can result in
> stopping source tasks not completing a final offset commit before considering
> the task fully stopped. This can allow rebalancing to proceed before offsets
> are fully committed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
