Hi Edward, I am not sure what the best practice is. Since it is checked in as part of the project, I considered it effectively part of its source. I suspect the method for collecting and taring the source files excluded it by accident (perhaps by many of these projects) and is something that could be fixed.
Thanks, Grant On Thu, Nov 26, 2015 at 5:33 AM, Edward Ribeiro <edward.ribe...@gmail.com> wrote: > Hi Grant, > > Sorry for my stupid question, but it is usually a best practice to include > such file in the src tar balls? I am certainly okay with including it, of > course. :) > > But I didn't see it in ZooKeeper 3.4.7, Hadoop 2.4.6 or Cassandra 3.0 > sources, for example. OTOH, I see the .gitattributes file in Hadoop src > folder with the content as below: > > # Auto detect text files and perform LF normalization > * text=auto > > *.cs text diff=csharp > *.java text diff=java > *.html text diff=html > *.py text diff=python > *.pl text diff=perl > *.pm text diff=perl > *.css text > *.js text > *.sql text > > *.sh text eol=lf > > *.bat text eol=crlf > *.cmd text eol=crlf > *.vcxproj text merge=union eol=crlf > *.csproj text merge=union eol=crlf > *.sln text merge=union eol=crlf > > > Cheers, > Eddie > > > On Wed, Nov 25, 2015 at 5:30 PM, Grant Henke <ghe...@cloudera.com> wrote: > > > The recent release source does not contain the repo's .gitignore file. > This > > is definitely not a major issue, but I wanted to bring it up so it could > be > > added in future releases. > > > > I downloaded the source from: > > > > > https://www.apache.org/dyn/closer.cgi?path=/kafka/0.9.0.0/kafka-0.9.0.0-src.tgz > > > > Thanks, > > Grant > > -- > > Grant Henke > > Software Engineer | Cloudera > > gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke > > > -- Grant Henke Software Engineer | Cloudera gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
