[
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067633#comment-15067633
]
Pierre-Yves Ritschard commented on KAFKA-3006:
----------------------------------------------
[~hachikuji] [~ijuma] I went through the re-factor. I had to fight gradle and
some unrelated tests which fail for me (on both trunk and this branch), which
explains the many commits. As it stands the branch builds and passes all tests.
Along the way I discovered that a SinkTask uses similar signatures, I propose
converging to the same signatures in a separate patch, to get this under way.
> Make collection default container type for sequences in the consumer API
> ------------------------------------------------------------------------
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
> Issue Type: Improvement
> Components: clients
> Affects Versions: 0.9.0.0
> Reporter: Pierre-Yves Ritschard
> Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of
> collection types. For example, subscribe() takes a list, but subscription()
> returns a set. Similarly for assign() and assignment(). We also have pause()
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a
> variable argument array, which means you have to copy the result of
> assignment() to an array if you want to pause all assigned partitions. We can
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection<String> topics);
> void subscribe(Collection<String> topics, ConsumerRebalanceListener);
> void assign(Collection<TopicPartition> partitions);
> void pause(Collection<TopicPartition> partitions);
> void resume(Collection<TopicPartition> partitions);
> void seekToBeginning(Collection<TopicPartition>);
> void seekToEnd(Collection<TopicPartition>);
> {code}
> This issues supersedes KAFKA-2991
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
