I am 100% pro smart Java clients that support KIP-35 and can use it to work with newer brokers. If this JIRA makes sense as a step in that direction, I think its great and remove my objection. I didn't see anything that looked like a plan toward full forward-backward compatibility, which is why I responded as I did...
Verification is good, but it looked like there was much complexity added toward very little benefits. On Thu, Aug 11, 2016 at 3:37 PM, Ashish Singh <asi...@cloudera.com> wrote: > Hey Gwen, > > I think this was more than a verification step, it was a building step > towards a backwards compatible clients or for clients that can select > feature based on brokers it is talking to. Are we now against the idea of > having smarter clients? This adds complexity to enable clients to inform > applications of incompatible broker versions, I think that is some value > add. In future, the api versions info can be used to take smarter decisions. > > On Wed, Aug 10, 2016 at 11:04 PM, Gwen Shapira <g...@confluent.io> wrote: > >> I hate doing this, because Ashish has really been good about following >> up on the PR, but I'm questioning the usefulness of this patch. >> >> It adds non-trivial complexity to the client... with not much return >> on the investment, as far as I can see? >> When I first suggested it, it was before KIP-35 was merged and >> released and the intent was to validate KIP-35 (since I have low >> opinion of protocols that aren't used). Since then KIP-35 was already >> released, the followup turned more complex than we expected, I think. >> And I'm wondering if it is worth it. >> >> The work and followup from Ashish is still super appreciated, but I >> think we need more than appreciation - adding complexity to already >> complex clients need to have functional justification... >> >> Anyway, I was out of the loop for ages, so feel free to yell at me for >> missing the obvious. >> >> Gwen >> >> On Tue, Aug 9, 2016 at 8:47 AM, Ashish Singh <asi...@cloudera.com> wrote: >> > Provided wrong link to PR, here is the PR >> > <https://github.com/apache/kafka/pull/1251> for KAFKA-3600. >> > >> > On Tue, Aug 9, 2016 at 9:45 AM, Ashish Singh <asi...@cloudera.com> >> wrote: >> > >> >> Hey Guys, >> >> >> >> KAFKA-3600 <https://issues.apache.org/jira/browse/KAFKA-3600> was part >> of >> >> KIP-35's proposal. KAFKA-3307 >> >> <https://issues.apache.org/jira/browse/KAFKA-3307>, >> >> adding ApiVersionsRequest/Response, was committed to 0.10.0.0, but >> >> KAFKA-3600, enhancing java clients, is still under review. Here is the >> PR >> >> <https://github.com/apache/kafka/pull/986> >> >> >> >> I have addressed all review comments and have been waiting for further >> >> reviews/ this to go in for quite some time. I will really appreciate if >> a >> >> committer can help with making progress on this. >> >> >> >> -- >> >> >> >> Regards, >> >> Ashish >> >> >> > >> > >> > >> > -- >> > >> > Regards, >> > Ashish >> >> >> >> -- >> Gwen Shapira >> Product Manager | Confluent >> 650.450.2760 | @gwenshap >> Follow us: Twitter | blog >> > > > > -- > > Regards, > Ashish -- Gwen Shapira Product Manager | Confluent 650.450.2760 | @gwenshap Follow us: Twitter | blog
