JIRA up - https://issues.apache.org/jira/browse/KAFKA-4602 PR up - https://github.com/apache/kafka/pull/2330 KIP wiki has been updated.
On Fri, Jan 6, 2017 at 8:16 AM, radai <radai.rosenbl...@gmail.com> wrote: > Will do (sorry for the delay). > and thank you. > > On Fri, Jan 6, 2017 at 7:56 AM, Ismael Juma <ism...@juma.me.uk> wrote: > >> Radai, you have more than enough votes to declare the vote successful. >> Maybe it's time to do so. :) Also, once you have done that, it would be >> good to move this KIP to the adopted table in the wiki. >> >> Thanks! >> >> Ismael >> >> On Fri, Jan 6, 2017 at 2:10 AM, Jun Rao <j...@confluent.io> wrote: >> >> > Hi, Radai, >> > >> > The new metrics look good. +1 on the KIP. >> > >> > Thanks, >> > >> > Jun >> > >> > On Fri, Dec 16, 2016 at 4:46 PM, radai <radai.rosenbl...@gmail.com> >> wrote: >> > >> > > I've added the 3 new metrics/sensors i've implemented to the KIP. >> > > >> > > at this point I would need to re-validate the functionality (which i >> > expect >> > > to do early january). >> > > >> > > code reviews welcome ;-) >> > > >> > > On Mon, Nov 28, 2016 at 10:37 AM, radai <radai.rosenbl...@gmail.com> >> > > wrote: >> > > >> > > > will do (only added a single one so far, the rest TBD) >> > > > >> > > > On Mon, Nov 28, 2016 at 10:04 AM, Jun Rao <j...@confluent.io> wrote: >> > > > >> > > >> Hi, Radai, >> > > >> >> > > >> Could you add a high level description of the newly added metrics >> to >> > the >> > > >> KIP wiki? >> > > >> >> > > >> Thanks, >> > > >> >> > > >> Jun >> > > >> >> > > >> On Wed, Nov 23, 2016 at 3:45 PM, radai <radai.rosenbl...@gmail.com >> > >> > > >> wrote: >> > > >> >> > > >> > Hi Jun, >> > > >> > >> > > >> > I've added the sensor you requested (or at least I think I did >> ....) >> > > >> > >> > > >> > On Fri, Nov 18, 2016 at 12:37 PM, Jun Rao <j...@confluent.io> >> wrote: >> > > >> > >> > > >> > > KafkaRequestHandlerPool >> > > >> > >> > > >> >> > > > >> > > > >> > > >> > >> > >