@Jason, thanks for your feedback! You're right, we are not considering the old consumer, since we rely on the KafkaConsumer#seek operations. I'm happy to update the KIP to make this explicit. About the second comment: I suppose that it would work, but I would like to include it to the test cases first. Do you know if this scenario has been test it in other clients?
Jorge El mié., 22 mar. 2017 a las 5:23, Dong Lin (<lindon...@gmail.com>) escribió: > Thanks for the KIP! > > +1 (non-binding) > > On Tue, Mar 21, 2017 at 6:24 PM, Becket Qin <becket....@gmail.com> wrote: > > > +1 > > > > Thanks for the KIP. The tool is very useful. > > > > On Tue, Mar 21, 2017 at 4:46 PM, Jason Gustafson <ja...@confluent.io> > > wrote: > > > > > +1 This looks super useful! Might be worth mentioning somewhere > > > compatibility with the old consumer. It looks like offsets in zk are > not > > > covered, which seems fine, but probably should be explicitly noted. > Maybe > > > you can also add a note saying that the tool can be used for old > > consumers > > > which have offsets stored in Kafka, but it will not protect against an > > > active consumer group in that case? > > > > > > Thanks, > > > Jason > > > > > > On Tue, Mar 14, 2017 at 10:13 AM, Dong Lin <lindon...@gmail.com> > wrote: > > > > > > > +1 (non-binding) > > > > > > > > On Tue, Mar 14, 2017 at 8:53 AM, Bill Bejeck <bbej...@gmail.com> > > wrote: > > > > > > > > > +1 > > > > > > > > > > On Tue, Mar 14, 2017 at 11:50 AM, Grant Henke <ghe...@cloudera.com > > > > > > wrote: > > > > > > > > > > > +1. Agreed. This is a great tool to have. > > > > > > > > > > > > On Tue, Mar 14, 2017 at 12:33 AM, Gwen Shapira < > g...@confluent.io> > > > > > wrote: > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > Nice job - this is going to be super useful. > > > > > > > > > > > > > > On Thu, Feb 23, 2017 at 4:46 PM, Jorge Esteban Quilcate Otoya < > > > > > > > quilcate.jo...@gmail.com> wrote: > > > > > > > > > > > > > > > Hi All, > > > > > > > > > > > > > > > > It seems that there is no further concern with the KIP-122. > > > > > > > > At this point we would like to start the voting process. > > > > > > > > > > > > > > > > The KIP can be found here: > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > > > > 122%3A+Add+Reset+Consumer+Group+Offsets+tooling > > > > > > > > > > > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > > Jorge. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > *Gwen Shapira* > > > > > > > Product Manager | Confluent > > > > > > > 650.450.2760 <(650)%20450-2760> | @gwenshap > > > > > > > Follow us: Twitter <https://twitter.com/ConfluentInc> | blog > > > > > > > <http://www.confluent.io/blog> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Grant Henke > > > > > > Software Engineer | Cloudera > > > > > > gr...@cloudera.com | twitter.com/gchenke | > > > linkedin.com/in/granthenke > > > > > > > > > > > > > > > > > > > > >
