Hi James, Yes, that's right, it will return all config values. For topic configs, that means falling back to the respective broker config value, which could also be a default. If we fallback to the broker config (whether it's a default or not), is_default will be true. Does this make sense? And do you have any concerns related to this?
Ismael On Sat, May 6, 2017 at 6:19 AM, James Cheng <wushuja...@gmail.com> wrote: > Hi Ismael, > > Thanks for the KIP. > > I see that in the ListConfigs Response protocol, that configs have an > is_default field. Does that mean that it will include *all* config values, > instead of just overridden ones? > > As an example, kafka-config.sh --describe on a topic will, right now, only > show overridden configs. With ListConfigs, will it show all default configs > for the topic, which includes the configs that were inherited from the > broker configs (which themselves, might also be defaults)? > > Thanks, > -James > > > On May 4, 2017, at 7:32 PM, Ismael Juma <ism...@juma.me.uk> wrote: > > > > Hi all, > > > > We've posted "KIP-133: List and Alter Configs Admin APIs" for discussion: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 133%3A+List+and+Alter+Configs+Admin+APIs > > > > This completes the first batch of AdminClient APIs so that topic, config > > and ACL management is supported. > > > > Please take a look. Your feedback is appreciated. > > > > Thanks, > > Ismael > >
