Thanks Jason !

I have just updated the KIP with DeleteRecordsOptions definition.


Paolo Patierno
Senior Software Engineer (IoT) @ Red Hat
Microsoft MVP on Azure & IoT
Microsoft Azure Advisor

Twitter : @ppatierno<http://twitter.com/ppatierno>
Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
Blog : DevExperience<http://paolopatierno.wordpress.com/>


________________________________
From: Jason Gustafson <ja...@confluent.io>
Sent: Wednesday, November 1, 2017 10:09 PM
To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP-204 : adding records deletion operation to the new 
Admin Client API

+1 (binding). Just one nit: the KIP doesn't define the DeleteRecordsOptions
object. I see it's empty in the PR, but we may as well document the full
API in the KIP.

-Jason


On Wed, Nov 1, 2017 at 2:54 PM, Guozhang Wang <wangg...@gmail.com> wrote:

> Made a pass over the PR and left some comments. I'm +1 on the wiki design
> page as well.
>
> On Tue, Oct 31, 2017 at 7:13 AM, Bill Bejeck <bbej...@gmail.com> wrote:
>
> > +1
> >
> > Thanks,
> > Bill
> >
> > On Tue, Oct 31, 2017 at 4:36 AM, Paolo Patierno <ppatie...@live.com>
> > wrote:
> >
> > > Hi all,
> > >
> > >
> > > because I don't see any further discussion around KIP-204 (
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 204+%3A+adding+records+deletion+operation+to+the+new+Admin+Client+API)
> > > and I have already opened a PR with the implementation, can we re-cover
> > the
> > > vote started on October 18 ?
> > >
> > > There are only "non binding" votes up to now.
> > >
> > > Thanks,
> > >
> > >
> > > Paolo Patierno
> > > Senior Software Engineer (IoT) @ Red Hat
> > > Microsoft MVP on Azure & IoT
> > > Microsoft Azure Advisor
> > >
> > > Twitter : @ppatierno<http://twitter.com/ppatierno>
> > > Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
> > > Blog : DevExperience<http://paolopatierno.wordpress.com/>
> > >
> > >
> > > ________________________________
> > > From: Viktor Somogyi <viktorsomo...@gmail.com>
> > > Sent: Wednesday, October 18, 2017 10:49 AM
> > > To: dev@kafka.apache.org
> > > Subject: Re: [VOTE] KIP-204 : adding records deletion operation to the
> > new
> > > Admin Client API
> > >
> > > +1 (non-binding)
> > >
> > > On Wed, Oct 18, 2017 at 8:23 AM, Manikumar <manikumar.re...@gmail.com>
> > > wrote:
> > >
> > > > + (non-binding)
> > > >
> > > >
> > > > Thanks,
> > > > Manikumar
> > > >
> > > > On Tue, Oct 17, 2017 at 7:42 AM, Dong Lin <lindon...@gmail.com>
> wrote:
> > > >
> > > > > Thanks for the KIP. +1 (non-binding)
> > > > >
> > > > > On Wed, Oct 11, 2017 at 2:27 AM, Ted Yu <yuzhih...@gmail.com>
> wrote:
> > > > >
> > > > > > +1
> > > > > >
> > > > > > On Mon, Oct 2, 2017 at 10:51 PM, Paolo Patierno <
> > ppatie...@live.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Hi all,
> > > > > > >
> > > > > > > I didn't see any further discussion around this KIP, so I'd
> like
> > to
> > > > > start
> > > > > > > the vote for it.
> > > > > > >
> > > > > > > Just for reference : https://cwiki.apache.org/
> > > > > > > confluence/display/KAFKA/KIP-204+%3A+adding+records+
> > > > > > > deletion+operation+to+the+new+Admin+Client+API
> > > > > > >
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Paolo Patierno
> > > > > > > Senior Software Engineer (IoT) @ Red Hat
> > > > > > > Microsoft MVP on Azure & IoT
> > > > > > > Microsoft Azure Advisor
> > > > > > >
> > > > > > > Twitter : @ppatierno<http://twitter.com/ppatierno>
> > > > > > > Linkedin : paolopatierno<http://it.
> linkedin.com/in/paolopatierno
> > >
> > > > > > > Blog : DevExperience<http://paolopatierno.wordpress.com/>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
>
>
> --
> -- Guozhang
>

Reply via email to