Hi, Any dev could comment on this? I'd quite like to launch the vote for this soon.
Thanks! On Fri, Nov 17, 2017 at 6:40 AM, James Cheng <wushuja...@gmail.com> wrote: > Ah, that's a great point. KIP-153 didn't *rename* the metric but changed > its meaning, yet we didn't seem to discuss compatibility much when we made > that change. > > If the Kafka devs can comment on the backwards-compatibility-ness of > metrics and how we treat that, that would be helpful. > > -James > > > On Nov 16, 2017, at 2:06 AM, charly molter <charly.mol...@gmail.com> > wrote: > > > > Yes James you are right. > > I wasn't sure what to do about it and followed what happened with > BytesOut > > in KIP-153 which completely changed meaning without any deprecation > window. > > I'm happy to adapt my KIP if the community thinks we should duplicate the > > metric for a while. > > > > Thanks! > > > > On Thu, Nov 16, 2017 at 8:13 AM, James Cheng <wushuja...@gmail.com> > wrote: > > > >> This KIP will break backwards compatibility for anyone who is using the > >> existing attribute names. > >> > >> Kafka devs, I believe that metrics are a supported interface, and so > this > >> would be a breaking change. In order to do this, we would need a > >> deprecation timeframe for the old metric, and a transition plan to the > new > >> name. Is that right? I'm not sure how we deprecate metrics... > >> > >> During the deprecation timeframe, we could duplicate the metric to the > new > >> name. > >> > >> -James > >> > >> On Nov 13, 2017, at 6:09 AM, charly molter <charly.mol...@gmail.com> > >> wrote: > >>> > >>> Hi, > >>> > >>> There doesn't seem to be much opposition to this KIP, I'll leave a > couple > >>> more days before starting the vote. > >>> > >>> Thanks! > >>> > >>> On Thu, Nov 9, 2017 at 1:59 PM, charly molter <charly.mol...@gmail.com > > > >>> wrote: > >>> > >>>> Hi, > >>>> > >>>> I'd like to start the discussion on KIP-225. > >>>> > >>>> This KIP tries to correct the way the consumer lag metrics are > reported > >> to > >>>> use built in tags from MetricName. > >>>> > >>>> Here's the link: > >>>> https://cwiki.apache.org/confluence/pages/viewpage. > >> action?pageId=74686649 > >>>> > >>>> Thanks! > >>>> -- > >>>> Charly Molter > >>>> > >>> > >>> > >>> > >>> -- > >>> Charly Molter > >> > >> > > > > > > -- > > Charly Molter > > -- Charly Molter
