+1 On Tue, 19 Dec 2017 at 19:13 Bill Bejeck <bbej...@gmail.com> wrote:
> +1 > > On Tue, Dec 19, 2017 at 1:21 PM, Matthias J. Sax <matth...@confluent.io> > wrote: > > > +1 > > > > On 12/19/17 9:23 AM, Guozhang Wang wrote: > > > Hello, > > > > > > I'm calling for a re-vote on the additional API changes in this KIP. > > While > > > working on the implementation I found it's better to add the following > > > functions for programmability: > > > > > > * Overloaded KafkaStreams constructor to allow overriding the `Time` > > object. > > > * Overloaded AbstractConfig#originalsWithPrefix() to allow specifying > > > whether or not to strip the prefix in the key of the returned map. > > > > > > The corresponding wiki page ( > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 220%3A+Add+AdminClient+into+Kafka+Streams%27+ClientSupplier) > > > has been updated. > > > > > > Gwen / Damian, could you take a quick look at the updated wiki page and > > > re-cast your vote? > > > > > > > > > Guozhang > > > > > > > > > > > > > > > On Mon, Nov 20, 2017 at 11:12 AM, Guozhang Wang <wangg...@gmail.com> > > wrote: > > > > > >> +1 from myself as well. > > >> > > >> I'm closing this KIP as accepted with 3 binding votes (Gwen, Damian, > me) > > >> and 3 non-binding votes (Colin, Ted, Matthias). > > >> > > >> > > >> Guozhang > > >> > > >> On Mon, Nov 20, 2017 at 9:56 AM, Damian Guy <damian....@gmail.com> > > wrote: > > >> > > >>> +1 > > >>> > > >>> On Mon, 20 Nov 2017 at 17:52 Gwen Shapira <g...@confluent.io> wrote: > > >>> > > >>>> +1 > > >>>> > > >>>> Make sense. We have a supplier for every other client type :) > > >>>> > > >>>> On Fri, Nov 17, 2017 at 1:33 PM Matthias J. Sax < > > matth...@confluent.io> > > >>>> wrote: > > >>>> > > >>>>> +1 > > >>>>> > > >>>>> On 11/17/17 9:35 AM, Ted Yu wrote: > > >>>>>> +1 > > >>>>>> > > >>>>>> On Fri, Nov 17, 2017 at 9:34 AM, Bill Bejeck <bbej...@gmail.com> > > >>>> wrote: > > >>>>>> > > >>>>>>> +1 > > >>>>>>> > > >>>>>>> Thanks, > > >>>>>>> Bill > > >>>>>>> > > >>>>>>> On Fri, Nov 17, 2017 at 12:13 PM, Colin McCabe < > cmcc...@apache.org > > >>>> > > >>>>> wrote: > > >>>>>>> > > >>>>>>>> +1 (non-binding) > > >>>>>>>> > > >>>>>>>> Colin > > >>>>>>>> > > >>>>>>>> On Tue, Nov 14, 2017, at 10:02, Guozhang Wang wrote: > > >>>>>>>>> Hello folks, > > >>>>>>>>> > > >>>>>>>>> I have filed a new KIP on adding AdminClient into Streams for > > >>>> internal > > >>>>>>>>> topic management. > > >>>>>>>>> > > >>>>>>>>> Please review and cast your vote on this thread. > > >>>>>>>>> > > >>>>>>>>> *https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > >>>>>>>> 220%3A+Add+AdminClient+into+Kafka+Streams%27+ClientSupplier > > >>>>>>>>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > >>>>>>>> 220%3A+Add+AdminClient+into+Kafka+Streams%27+ClientSupplier>* > > >>>>>>>>> > > >>>>>>>>> The discussion is in another thread so if you have detailed > > >>>> questions > > >>>>>>>>> please chime in there. > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> -- Guozhang > > >>>>>>>> > > >>>>>>> > > >>>>>> > > >>>>> > > >>>>> > > >>>> > > >>> > > >> > > >> > > >> > > >> -- > > >> -- Guozhang > > >> > > > > > > > > > > > > > >
