Sorry for the double email. I've compiled the fixes made by the other PR and it fixes the Windows problem: https://github.com/apache/kafka/pull/5603
It triggers a few errors in the unit tests, which is probably due to the order changes of which files are deleted. Let's continue the discussion there? On 3 September 2018 at 08:24, Stephane Maarek < steph...@simplemachines.com.au> wrote: > Hi Ismael, thanks for having a look! > > https://github.com/apache/kafka/pull/4947/files does not fix it for me. > > But this one does: https://github.com/apache/kafka/pull/4431 > It produces the following log: https://pastebin.com/NHeAcc6v > As you can see the folders do get renamed, it gives the user a few odd > WARNs, but I checked and the directories are fully gone nonetheless. > > I think the ideas of the PRs go back all along to > https://github.com/apache/kafka/pull/154/files or > https://github.com/apache/kafka/pull/1757 > > I couldn't find how to map both PRs to the new Kafka codebase, > unfortunately. > > On 3 September 2018 at 03:26, Ismael Juma <ism...@juma.me.uk> wrote: > >> Hi Stephane, >> >> Does https://github.com/apache/kafka/pull/4947/files fix it for you? >> >> Ismael >> >> On Sun, Sep 2, 2018 at 11:25 AM Stephane Maarek < >> steph...@simplemachines.com.au> wrote: >> >> > Hi, >> > >> > I've seen Dong has done some work on >> > https://issues.apache.org/jira/browse/KAFKA-7278 which is said from the >> > comments that it could have possibly fixed >> > https://issues.apache.org/jira/browse/KAFKA-1194. >> > >> > I tested and it is unfortunately not the case... >> > I have posted in KAFKA-1194 a way to reproduce the issue in a >> deterministic >> > way: >> > =========== >> > C:\kafka_2.11-2.1.0-SNAPSHOT>bin\windows\kafka-server-start.bat >> > config\server.properties >> > >> > C:\kafka_2.11-2.1.0-SNAPSHOT>kafka-topics.bat --zookeeper >> 127.0.0.1:2181 >> > --topic second_topic --create --partitions 3 --replication-factor 1 >> > >> > C:\kafka_2.11-2.1.0-SNAPSHOT>kafka-console-producer.bat --broker-list >> > 127.0.0.1:9092 --topic second_topic >> > >hello >> > >world >> > >hello >> > >Terminate batch job (Y/N)? Y >> > >> > C:\kafka_2.11-2.1.0-SNAPSHOT>kafka-topics.bat --zookeeper >> 127.0.0.1:2181 >> > --topic second_topic --delete >> > ============ >> > >> > >> > I usually wouldn't push for any issues for windows to be fixed, but this >> > one is triggered from basic CLI usage and triggers a full broker failure >> > that can't be recovered. >> > It actually completely destroys the faith of Kafka newcomers learning >> using >> > Windows (which are 50% of the users I have in my course). >> > >> > I'm happy to help out in any way I can to test any patch. >> > >> > Thanks >> > Stephane >> > >> > >
