Thank you for the explanation regarding the internals, I have edited the KIP accordingly and updated the Javadoc. About the possible data loss when altering changelog config, I think we can improve by doing (one of) the following.
1) Add a warning in the comments that clearly states what might happen when change logging is disabled and adjust it when persistent stores are added. 2) Change `withLoggingDisabled` to `minimizeLogging`. Instead of disabling logging, a call to this method minimizes the topic size by aggressively removing the records emitted downstream by the suppress operator. I believe this can be achieved by setting `delete.retention.ms=0` in the topic config. 3) Remove `withLoggingDisabled` from the proposal. 4) Leave both methods as-proposed, as you indicated, this is in line with the other parts of the Streams API A user might want to disable logging when downstream is not a Kafka topic but some other service that does not benefit from atleast-once-delivery of the suppressed records in case of failover or rebalance. Seeing as it might cause data loss, the methods should not be used lightly and I think some comments are warranted. Personally, I rely purely on Kafka to prevent data loss even when a store persisted locally, so when support is added for persistent suppression, I feel the comments may stay. Maarten
