Thanks for the KIP! I was just comparing this KIP with KIP-451 (even if I did not yet make a sorrow read over this KIP), and I agree that there is a big overlap. It seems that KIP-456 might subsume KIP-451.
Let's wait on Patrick's input to see how to proceed. -Matthias On 4/25/19 12:03 AM, Jukka Karvanen wrote: > Hi, > > If you want to see or test the my current idea of the implementation of > this KIP, you can check it out in my repo: > https://github.com/jukkakarvanen/kafka/compare/trunk...jukkakarvanen:KAFKA-8233_InputOutputTopics > > > After my test with KPI-451 I do not see need for add methods for > Iterables, but waiting Patrick's clarification of the use case. > > Jukka > > > ti 23. huhtik. 2019 klo 15.37 Jukka Karvanen (jukka.karva...@jukinimi.com) > kirjoitti: > >> Hi All, >> >> I would like to start the discussion on KIP-456: Helper classes to make it >> simpler to write test logic with TopologyTestDriver: >> >> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-456%3A+Helper+classes+to+make+it+simpler+to+write+test+logic+with+TopologyTestDriver >> >> >> There is also related KIP adding methods to TopologyTestDriver: >> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-451%3A+Make+TopologyTestDriver+output+iterable >> >> >> I added those new Iterable based methods to this TestOutputTopic even not >> tested those myself yet. >> So this version contains both my original List and Map based methods and >> these new one. >> Based on the discussion some of these can be dropped, if those are seen as >> redundant. >> >> Best Regards, >> Jukka >> >> >
signature.asc
Description: OpenPGP digital signature
