I think that sounds reasonable - I updated the KIP and I will remove the constructor that takes in only partitions.
On Thu, May 2, 2019 at 4:44 AM Andy Coates <a...@confluent.io> wrote: > Rather than adding overloaded constructors, which can lead to API bloat, > how about using a builder pattern? > > I see it’s already got some constructor overloading, but we could add a > single new constructor that takes just the name, and support everything > else being set via builder methods. > > This would result in a better long term api as the number of options > increases. > > Sent from my iPhone > > > On 30 Apr 2019, at 16:28, Almog Gavra <al...@confluent.io> wrote: > > > > Hello Everyone, > > > > I'd like to start a discussion on KIP-464: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-464%3A+Default+Replication+Factor+for+AdminClient%23createTopic > > > > It's about allowing users of the AdminClient to supply only a partition > > count and to use the default replication factor configured by the kafka > > cluster. Happy to receive any and all feedback! > > > > Cheers, > > Almog >
