Hey Bruno! This all looks pretty good to me, but one suggestion I have is to supplement each of the metrics with some info on how the user can control them. In other words, which options could/should they set in RocksDBConfigSetter should they discover a particular bottleneck?
I don't think this necessarily needs to go into the KIP, but I do think it should be included in the docs somewhere (happy to help build up the list of associated options when the time comes) Thanks! Sophie On Fri, May 17, 2019 at 2:54 PM Bruno Cadonna <br...@confluent.io> wrote: > Hi all, > > this KIP describes the extension of the Kafka Streams' metrics to include > RocksDB's internal statistics. > > Please have a look at it and let me know what you think. Since I am not a > RocksDB expert, I am thankful for any additional pair of eyes that > evaluates this KIP. > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-471:+Expose+RocksDB+Metrics+in+Kafka+Streams > > Best regards, > Bruno >
