+1 (binding)

On 7/31/19 8:36 AM, Guozhang Wang wrote:
> Thanks for the update! +1 (binding).
> 
> On Tue, Jul 30, 2019 at 11:42 PM Levani Kokhreidze <levani.co...@gmail.com>
> wrote:
> 
>> Hello Guozhang,
>>
>> Thanks for the feedback. That’s an interesting point. To be honest, I
>> totally missed it. I wasn’t aware that there’s `groupBy` possibility on
>> KTable.
>> I don’t see any reasons why not to add same functionality to KTable
>> interface.
>>
>> I’ve updated the KIP:
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-221%3A+Enhance+DSL+with+Connecting+Topic+Creation+and+Repartition+Hint
>> <
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-221:+Enhance+DSL+with+Connecting+Topic+Creation+and+Repartition+Hint
>>>
>> Please let me know if you have any other questions and/or concerns.
>>
>> Regards,
>> Levani
>>
>>> On Jul 31, 2019, at 1:24 AM, Guozhang Wang <wangg...@gmail.com> wrote:
>>>
>>> Hello Levani,
>>>
>>> Thanks for the KIP! Just got a quick question here about the scope: why
>> do
>>> we only want this for `KStream`, not `KTable#groupBy` for example?
>>>
>>>
>>> Guozhang
>>>
>>>
>>> On Tue, Jul 30, 2019 at 1:27 PM Bill Bejeck <bbej...@gmail.com> wrote:
>>>
>>>> Thanks for the KIP Levani.
>>>>
>>>> +1 (binding)
>>>>
>>>> -Bill
>>>>
>>>> On Tue, Jul 30, 2019 at 3:37 PM Levani Kokhreidze <
>> levani.co...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hello,
>>>>>
>>>>> Still waiting for feedback on this KIP.
>>>>> Please let me know if you have any concerns and/or questions.
>>>>>
>>>>> Regards,
>>>>> Levani
>>>>>
>>>>>
>>>>>> On Jul 24, 2019, at 8:20 PM, Sophie Blee-Goldman <sop...@confluent.io
>>>
>>>>> wrote:
>>>>>>
>>>>>> Looks good! Thanks Levani,
>>>>>>
>>>>>> +1 (non-binding)
>>>>>>
>>>>>> Sophie
>>>>>>
>>>>>> On Tue, Jul 23, 2019 at 2:16 PM Levani Kokhreidze <
>>>>> levani.co...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Hello,
>>>>>>>
>>>>>>> I’d like to initialize voting on KIP-221:
>>>>>>>
>>>>>
>>>>
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-221%3A+Enhance+KStream+with+Connecting+Topic+Creation+and+Repartition+Hint
>>>>>>> <
>>>>>>>
>>>>>
>>>>
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-221:+Enhance+KStream+with+Connecting+Topic+Creation+and+Repartition+Hint
>>>>>>>>
>>>>>>> If there’re any more concerns about the KIP, happy to discuss
>> further.
>>>>>>>
>>>>>>> Regards,
>>>>>>> Levani
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> -- Guozhang
>>
>>
> 

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to