Thanks again JB for reviewing and applying the commits. I have written a blog article about how it all works here: http://coderthoughts.blogspot.com/2013/10/role-based-access-control-for-karaf.html
Best regards, David On 8 October 2013 16:50, Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > Awesome, thanks a lot David. I will review it tomorrow morning. > > Regards > JB > > > On 10/08/2013 05:44 PM, David Bosschaert wrote: >> >> Hi all, >> >> I have the pull request for KARAF-2455 (role-based security for OSGi >> Services) and KARAF-2442 (role-based security for Karaf Shell >> Commands) ready. >> Since KARAF-2442 builds on top of KARAF-2455 (thanks Christian for >> suggesting this originally) I included both in a single pull requests >> as two separate commits: https://github.com/apache/karaf/pull/22 >> >> One note - I have included lots of unit tests (generally > 95% >> coverage for any of the code I touched) but am also planning to add >> some system tests. However I'd like to add those system tests >> separately later. >> >> Feedback appreciated, >> >> David >> >> On 19 September 2013 11:22, Jean-Baptiste Onofré <j...@nanthrax.net> wrote: >>> >>> Hi David, >>> >>> awesome, thanks for the update. I just started to review the patches. I >>> will >>> apply tonight or tomorrow. >>> >>> Thanks again, >>> Regards >>> JB >>> >>> >>> On 09/19/2013 11:56 AM, David Bosschaert wrote: >>>> >>>> >>>> Hi all, >>>> >>>> Just a little status update on this... >>>> I have since implemented most of KARAF-2455 (role-based security for >>>> OSGi >>>> Services) and KARAF-2442 (role-based security for Karaf Shell Commands). >>>> They build on top of what I did for KARAF-2434 and KARAF-2435. Once >>>> those >>>> are merge I can rebase my implementation on trunk and will provide >>>> patches >>>> to apply... >>>> >>>> Cheers, >>>> >>>> David >>>> >>>> >>>> On 26 August 2013 10:22, Jean-Baptiste Onofré <j...@nanthrax.net> wrote: >>>> >>>>> Thanks David, >>>>> >>>>> it makes sense. >>>>> >>>>> Regards >>>>> JB >>>>> >>>>> >>>>> On 08/26/2013 11:16 AM, David Bosschaert wrote: >>>>> >>>>>> Since I think the general consensus here is that it would be good to >>>>>> have >>>>>> a >>>>>> general security mechanism for OSGi services I have created a JIRA for >>>>>> that >>>>>> (KARAF-2455) and noted that role-based security for the commands can >>>>>> be >>>>>> built on top of this (KARAF-2442). >>>>>> >>>>>> Cheers, >>>>>> >>>>>> David >>>>>> >>>>>> >>>>> -- >>>>> Jean-Baptiste Onofré >>>>> jbono...@apache.org >>>>> http://blog.nanthrax.net >>>>> Talend - http://www.talend.com >>>>> >>>> >>> >>> -- >>> Jean-Baptiste Onofré >>> jbono...@apache.org >>> http://blog.nanthrax.net >>> Talend - http://www.talend.com > > > -- > Jean-Baptiste Onofré > jbono...@apache.org > http://blog.nanthrax.net > Talend - http://www.talend.com
