Hello The process is perfectly fine ;) Just create a GH issue and/or PR and we can include it in the next release. By simply looking at https://github.com/ops4j/org.ops4j.pax.web/pull/1734/files I can't _feel_ the change, let me just run all the tests (btw - did you run it? I'd be happy to get a feedback about how easy/hard it is to run the tests :).
I plan to release 8.0.5 to be included in Karaf 4.4.1 and we should be ready this week (with Pax Web 8.0.5). thanks for the issue+PR! regards Grzegorz Grzybek wt., 28 cze 2022 o 14:04 Siano, Stephan <stephan.si...@sap.com.invalid> napisał(a): > Hi, > > I have a meta-question concerning extensions in pax-web. > > With pax-web 8.0.4 (which is the latest version of the pax-web in the > karaf 4.4 release) thanks to Grzegorz parsing of global and war specific > context.xml files works in pax-web-tomcat. > > However there is still one limitation: If the context configuration > contains a login valve unlike in plain Tomcat the default login valve will > be added in addition to the one from the context configuration. > > The resolution is a rather easy change in the > org.ops4j.pax.web.service.tomcat.internal.OsgiContextConfiguration class. > > What is the process for this? I created > https://github.com/ops4j/org.ops4j.pax.web/issues/1733 for this topic and > I can also contribute a pull request to pax-web for it. Is this the way to > go, or did I do something wrong there? > > Best regards > Stephan >
