RE: Karaf 4.4/Pax-Web 8.0.4 Tomcat login valve handling

[Siano, Stephan]

Hi Grzegorz,

The change is actually simpler than it looks, I just moved some code further 
down. The only code that is actually new is 
                                // Has an authenticator been configured already?
                                authenticationValve = (Valve) 
context.getAuthenticator();
                                if (authenticationValve == null) {
(and the closing bracket for the if statement).

I did run the tests (with -Ptomcat, so I didn't run the integration tests for 
jetty and undertow). In my (Windows) environment a few tests failed (three in 
the non-OSGi integration test and two Tomcat integration tests, but I got the 
same errors before the change).

Tests are always a bit difficult or run in foreign environments for projects as 
big as pax-web, but it worked relatively smooth for me.

Thanks for the quick response. I really appreciate this!

Best regards
Stephan 


-----Original Message-----
From: Grzegorz Grzybek <gr.grzy...@gmail.com> 
Sent: Tuesday, 28 June 2022 14:32
To: dev@karaf.apache.org
Subject: Re: Karaf 4.4/Pax-Web 8.0.4 Tomcat login valve handling

Hello

The process is perfectly fine ;) Just create a GH issue and/or PR and we can 
include it in the next release.
By simply looking at
https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fops4j%2Forg.ops4j.pax.web%2Fpull%2F1734%2Ffiles&amp;data=05%7C01%7Cstephan.siano%40sap.com%7Ce41771998d754338a7b808da59024236%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C637920163477527906%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=SZoEfSn3A64QznDxAt3B9pXmI0keapseqpj344a2S54%3D&amp;reserved=0
 I can't _feel_ the change, let me just run all the tests (btw - did you run 
it? I'd be happy to get a feedback about how easy/hard it is to run the tests 
:).

I plan to release 8.0.5 to be included in Karaf 4.4.1 and we should be ready 
this week (with Pax Web 8.0.5).

thanks for the issue+PR!
regards
Grzegorz Grzybek

wt., 28 cze 2022 o 14:04 Siano, Stephan <stephan.si...@sap.com.invalid>
napisał(a):

> Hi,
>
> I have a meta-question concerning extensions in pax-web.
>
> With pax-web 8.0.4 (which is the latest version of the pax-web in the 
> karaf 4.4 release) thanks to Grzegorz parsing of global and war 
> specific context.xml files works in pax-web-tomcat.
>
> However there is still one limitation: If the context configuration 
> contains a login valve unlike in plain Tomcat the default login valve 
> will be added in addition to the one from the context configuration.
>
> The resolution is a rather easy change in the 
> org.ops4j.pax.web.service.tomcat.internal.OsgiContextConfiguration class.
>
> What is the process for this? I created
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Fops4j%2Forg.ops4j.pax.web%2Fissues%2F1733&amp;data=05%7C01%7C
> stephan.siano%40sap.com%7Ce41771998d754338a7b808da59024236%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C637920163477527906%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=PJw3NcjWkWFmjPBaWTo23TaoyuVFPRI9Vri6UcIQyI4%3D&amp;reserved=0
>  for this topic and I can also contribute a pull request to pax-web for it. 
> Is this the way to go, or did I do something wrong there?
>
> Best regards
> Stephan
>