Hi, I checked with Mario. He had hit the no-managed-deps issue with main branch and fixed it with the commit https://github.com/apache/incubator-kie-drools/commit/7d11b928a43b3f47bda6aac9ae4f79000d3ece72
The commit includes kie-dmn-core-jsr223, kie-dmn-pmml-tests-trusty and kie-pmml-compiler-api. So I filed a backport PR to pick only those profile fixes for 10.0.x. https://github.com/apache/incubator-kie-drools/pull/6106 Mario said he couldn't reproduce the no-managed-deps issue with 10.0.0-rc1 sources somehow (me neither), so we are not 100% sure if the issue is completely resolved, but as far as I checked with a shell script, the projects which contain <dependency> inside <profile> were only those 3 projects. Regards, Toshiya On Tue, Oct 1, 2024 at 4:35 AM ricardo zanini fernandes < [email protected]> wrote: > Folks, > > Mario pointed this PR on main: > > https://github.com/apache/incubator-kie-drools/commit/7d11b928a43b3f47bda6aac9ae4f79000d3ece72#diff-3996befe028d9a45cdd34de663ca46540723ace560396ac3af8b880ba47332eaL81 > . > > I applied the pom.xml changes to remove the profiles and add this > dependency: > > """ > <dependency> > <groupId>org.glassfish.jaxb</groupId> > <artifactId>jaxb-runtime</artifactId> > </dependency> > """ > > It worked for this module, but now it's failing ahead: > > """ > [INFO] --- enforcer:3.0.0-M2:enforce (no-managed-deps) @ > kie-dmn-core-jsr223 --- > [WARNING] Rule 0: org.commonjava.maven.enforcer.rule.EnforceManagedDepsRule > failed with message: > The following 1 dependencies are NOT using a managed version: > > - org.openjdk.nashorn:nashorn-core:jar > """ > > @ Mario, I believe your fix worked, but we could also review other modules? > > Cheers! > > On Mon, Sep 30, 2024 at 2:58 AM Gabriele Cardosi < > [email protected]> > wrote: > > > Hi all > > drools/build-parent/pom.xml#399 > > > > <dependency> > > > <groupId>org.glassfish.jaxb</groupId> > > > <artifactId>jaxb-runtime</artifactId> > > > <version>${version.org.glassfish.jaxb}</version> > > > > > > > Regards, > > Gabriele > > > > > > Il giorno lun 30 set 2024 alle ore 04:16 Toshiya Kobayashi < > > [email protected]> ha scritto: > > > > > Hmm, I downloaded the zip file again to ensure it is the latest > > > version. Then I tried the steps. > > > > > > I didn't hit the error and the build was successful. Can someone > > > double-check? > > > > > > It looks to me that kie-pmml-compiler-api/pom.xml uses a managed > version. > > > ``` > > > <profiles> > > > <profile> > > > <id>java11-pmml</id> > > > <activation> > > > <jdk>[11,)</jdk> > > > </activation> > > > <dependencies> > > > <dependency> > > > <groupId>org.glassfish.jaxb</groupId> > > > <artifactId>jaxb-runtime</artifactId> > > > </dependency> > > > </dependencies> > > > </profile> > > > </profiles> > > > ``` > > > > > > Regards, > > > Toshiya > > > > > > On Sat, Sep 28, 2024 at 8:11 AM ricardo zanini fernandes < > > > [email protected]> wrote: > > > > > > > Hi guys! > > > > > > > > While building drools I'm getting the following error: > > > > > > > > """ > > > > [INFO] --- enforcer:3.0.0-M2:enforce (no-managed-deps) @ > > > > kie-pmml-compiler-api --- > > > > [WARNING] Rule 0: > > > org.commonjava.maven.enforcer.rule.EnforceManagedDepsRule > > > > failed with message: > > > > The following 1 dependencies are NOT using a managed version: > > > > > > > > - org.glassfish.jaxb:jaxb-runtime:jar > > > > """ > > > > > > > > The build failures there and skip the rest. > > > > > > > > What I did was: > > > > 1. Download the rc1 zip, unzip, cd into drools > > > > 2. Run git init > > > > 3. Run mvn clean install -DskipTests -Dfull > > > > > > > > Cheers! > > > > > > > > On Wed, Sep 25, 2024 at 2:22 AM Toshiya Kobayashi < > > > > [email protected]> wrote: > > > > > > > > > > I recommend running the RAT tool: > https://creadur.apache.org/rat/ > > > and > > > > > checking things for headers, NOTICE files, etc. > > > > > > > > > > Thank you, I was not aware of the tools and it was already > configured > > > in > > > > > pom.xml. > > > > > > > > > > When I run `mvn apache-rat:check` for drools, it reported that > there > > > are > > > > > some missing license headers. I filed a GH issue and PR. > > > > > > > > > > https://github.com/apache/incubator-kie-drools/issues/6098 > > > > > https://github.com/apache/incubator-kie-drools/pull/6099 > > > > > > > > > > Regards, > > > > > Toshiya > > > > > > > > > > On Wed, Sep 25, 2024 at 6:12 AM Tiago Bento <[email protected] > > > > > > wrote: > > > > > > > > > > > I'm not sure how other projects do it, but I'm guessing the > process > > > of > > > > > > publishing a release candidate for public consumption is > different > > > > > > from a proper final release... From what I understand, release > > > > > > candidates published to > > > > > > https://dist.apache.org/repos/dist/dev/incubator/kie/10.0.0-rc1, > > if > > > > > > approved, need to be the exact same artifacts as the ones that > will > > > > > > compose the final release. For this reason, we can't have > "release > > > > > > candidate" artifacts with the `-rcX` prefix as their version, > since > > > > > > they need to be, bit by bit, equal to the release itself. > > > > > > > > > > > > When one of our release candidates is approved both by us and the > > > > > > IPMC, the process of publishing it as a final release will be > > > creating > > > > > > a tag `10.0.0` pointing to the exact same commit as the > > `10.0.0-rcX` > > > > > > tag. Same is true for the artifacts. Our release publishing > > > automation > > > > > > will download from > > > > > > https://dist.apache.org/repos/dist/dev/incubator/kie/10.0.0-rc1/ > > and > > > > > > push to whatever places each artifact is released to (E.g., NPM, > > > > > > DockerHub, OperatorHub, VS Code Marketplace, Chrome Web Store > etc). > > > > > > > > > > > > On Tue, Sep 24, 2024 at 2:03 PM Jason Porter < > > > [email protected]> > > > > > > wrote: > > > > > > > > > > > > > > I recommend running the RAT tool: > > https://creadur.apache.org/rat/ > > > > and > > > > > > checking things for headers, NOTICE files, etc. > > > > > > > > > > > > > > On 2024/09/24 09:23:20 Toshiya Kobayashi wrote: > > > > > > > > Hi all, > > > > > > > > > > > > > > > > It's great that we see incubator-kie-10.0.0-rc1-sources.zip > in > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/kie/10.0.0-rc1/ > > > > > > > > > > > > > > > > Now should we verify the sources.zip? > > > > > > > > > > > > > > > > If yes, what should we test? > > > > > > > > > > > > > > > > I think of: > > > > > > > > > > > > > > > > - Build the project > > > > > > > > - Run all unit tests > > > > > > > > - Run my own application (which uses the 10.0.0 jars as > > library) > > > > and > > > > > > > > confirm if it works > > > > > > > > - Build and compare checksum with artifacts under > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachekie-1005/ > > > > > > ? > > > > > > > > > > > > > > > > Anyone, feel free to share your thoughts. > > > > > > > > > > > > > > > > Just FYI for drools, I have done archetypes and kjar tests as > > > > sanity > > > > > > checks > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://docs.google.com/spreadsheets/d/1RP64VxjAbdWQX-w2ZgnAFSDdaoheJapIFdp29TFc5w0/edit?gid=0#gid=0 > > > > > > > > > > > > > > > > Regards, > > > > > > > > Toshiya > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > To unsubscribe, e-mail: [email protected] > > > > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: [email protected] > > > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > > > > > > > > > > > > > > >
