risdenk commented on a change in pull request #65: KNOX-1774 - Introducing 
environment variables in gateway/knoxcli/ldap/knoxshell scripts for 
customization
URL: https://github.com/apache/knox/pull/65#discussion_r263780117
 
 

 ##########
 File path: gateway-release/src/assembly.xml
 ##########
 @@ -46,6 +46,14 @@
             </includes>
             <fileMode>0755</fileMode>
         </fileSet>
+        <fileSet>
 
 Review comment:
   I don't think this is necessary? Lines 41-48 should handle this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to