risdenk commented on a change in pull request #65: KNOX-1774 - Introducing environment variables in gateway/knoxcli/ldap/knoxshell scripts for customization URL: https://github.com/apache/knox/pull/65#discussion_r263780406
########## File path: gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java ########## @@ -81,18 +81,15 @@ private static final GatewayMessages log = MessagesFactory.get( GatewayMessages.class ); - private static final String GATEWAY_CONFIG_DIR_PREFIX = "conf"; + private static final String GATEWAY_CONFIG_DIR_PREFIX = "conf/"; Review comment: Should at least be `File.separator` - Weird to have it concatenated on here though. Doesn't match other ones right below it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
