[
https://issues.apache.org/jira/browse/KNOX-1820?focusedWorklogId=213253&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213253
]
ASF GitHub Bot logged work on KNOX-1820:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/19 16:53
Start Date: 14/Mar/19 16:53
Worklog Time Spent: 10m
Work Description: rlevas commented on issue #72: KNOX-1820 - Cleanup
KeystoreService implementations and add unit tests
URL: https://github.com/apache/knox/pull/72#issuecomment-472960625
I am not sure what the Travis failure. The unit tests run fine for me:
```
mvn -T1C verify -Dsurefire.useFile=false
-Djavax.net.ssl.trustStorePassword=changeit
-DargLine="-Djdk.net.URLClassPath.disableClassPathURLCheck=true" -B -V
...
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 10:32 min (Wall Clock)
[INFO] Finished at: 2019-03-14T12:41:39-04:00
[INFO] Final Memory: 338M/1964M
[INFO]
------------------------------------------------------------------------
```
Plus the error is not in a touched class:
```
ERROR]
RemoteConfigurationRegistryJAASConfigTest.shouldRaiseAnErrorWithMeaningfulErrorMessageIfAuthLoginConfigCannotBeRead
Expected test to throw (an instance of
org.apache.knox.gateway.config.ConfigurationException and exception with
message a string starting with "Error while getting secure configuration. This
error usually indicates an issue within the supplied JAAS configuration")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 213253)
Time Spent: 2h 50m (was: 2h 40m)
> Cleanup KeystoreService implementations and add unit tests
> ----------------------------------------------------------
>
> Key: KNOX-1820
> URL: https://issues.apache.org/jira/browse/KNOX-1820
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Reporter: Robert Levas
> Assignee: Robert Levas
> Priority: Minor
> Labels: cleanup
> Fix For: 1.3.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> {{org.apache.knox.gateway.services.security.impl.BaseKeystoreService}} should
> be an abstract class extended by
> {{org.apache.knox.gateway.services.security.impl.CMFKeystoreService}} and
> {{DefaultKeystoreService}.
> Unit test for these classes are missing and should be added.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
