[ 
https://issues.apache.org/jira/browse/KNOX-1820?focusedWorklogId=213422&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213422
 ]

ASF GitHub Bot logged work on KNOX-1820:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Mar/19 21:20
            Start Date: 14/Mar/19 21:20
    Worklog Time Spent: 10m 
      Work Description: rlevas commented on issue #72: KNOX-1820 - Cleanup 
KeystoreService implementations and add unit tests
URL: https://github.com/apache/knox/pull/72#issuecomment-473067835
 
 
   > Ah I wasn't clear. I meant there are references to `toFile()` and 
operations on the resulting `File`.
   
   Fixed...
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 213422)
    Time Spent: 3h 40m  (was: 3.5h)

> Cleanup KeystoreService implementations and add unit tests
> ----------------------------------------------------------
>
>                 Key: KNOX-1820
>                 URL: https://issues.apache.org/jira/browse/KNOX-1820
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Server
>            Reporter: Robert Levas
>            Assignee: Robert Levas
>            Priority: Minor
>              Labels: cleanup
>             Fix For: 1.3.0
>
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> {{org.apache.knox.gateway.services.security.impl.BaseKeystoreService}} should 
> be an abstract class extended by 
> {{org.apache.knox.gateway.services.security.impl.CMFKeystoreService}} and 
> {{DefaultKeystoreService}.  
> Unit test for these classes are missing and should be added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to