[
https://issues.apache.org/jira/browse/KNOX-2018?focusedWorklogId=320955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320955
]
ASF GitHub Bot logged work on KNOX-2018:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/19 22:51
Start Date: 30/Sep/19 22:51
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #158: KNOX-2018 -
KnoxShellTable Filtering needs greaterThan and lessThan, equals Methods
URL: https://github.com/apache/knox/pull/158#discussion_r329819749
##########
File path:
gateway-shell/src/main/java/org/apache/knox/gateway/shell/table/KnoxShellTableFilter.java
##########
@@ -82,4 +84,23 @@ public KnoxShellTable greaterThan(Comparable<? extends
Object> comparable) throw
return filter(s -> s.compareTo(comparable) > 0);
}
+ @SuppressWarnings("unchecked")
+ public KnoxShellTable lessThan(Comparable<? extends Object> comparable)
throws KnoxShellTableFilterException {
+ return filter(s -> s.compareTo(comparable) < 0);
+ }
+
+ @SuppressWarnings("unchecked")
+ public KnoxShellTable greaterThanOrEqualTo(Comparable<? extends Object>
comparable) throws KnoxShellTableFilterException {
+ return filter(s -> s.compareTo(comparable) > 0 || s.compareTo(comparable)
== 0);
+ }
+
+ @SuppressWarnings("unchecked")
+ public KnoxShellTable lessThanOrEqualTo(Comparable<? extends Object>
comparable) throws KnoxShellTableFilterException {
+ return filter(s -> s.compareTo(comparable) < 0 || s.compareTo(comparable)
== 0);
Review comment:
Should be `.equals()` as well for gt and lt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 320955)
Time Spent: 3h 50m (was: 3h 40m)
> KnoxShellTable Filtering needs greaterThan and lessThan, equals Methods
> -----------------------------------------------------------------------
>
> Key: KNOX-2018
> URL: https://issues.apache.org/jira/browse/KNOX-2018
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxShell
> Reporter: Larry McCay
> Assignee: Ljmiv
> Priority: Major
> Labels: noob
> Fix For: 1.4.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> It would be useful to have greaterThan and lessThan filtering for
> KnoxShellTable.
> Currently we have a regex match to filter matches.
> Some easier methods for greaterThan, lessThan, equals, equalsIgnoreCare, etc
> would be very helpful as regex for those things may be possible but more
> complicated than necessary.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
