[
https://issues.apache.org/jira/browse/KNOX-2018?focusedWorklogId=321240&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321240
]
ASF GitHub Bot logged work on KNOX-2018:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/19 13:06
Start Date: 01/Oct/19 13:06
Worklog Time Spent: 10m
Work Description: lmccay4 commented on pull request #158: KNOX-2018 -
KnoxShellTable Filtering needs greaterThan and lessThan, equals Methods
URL: https://github.com/apache/knox/pull/158#discussion_r330045385
##########
File path:
gateway-shell/src/test/java/org/apache/knox/gateway/shell/table/KnoxShellTableFilterTest.java
##########
@@ -50,18 +51,86 @@ public void testRegexFilter() throws
KnoxShellTableFilterException {
@Test
public void testGreaterThanFilter() throws KnoxShellTableFilterException,
ParseException {
- assertEquals(TABLE.filter().name("Column
Integer").greaterThan(5).getRows().size(), 2);
- assertEquals(TABLE.filter().name("Column
Integer").greaterThan(25).getRows().size(), 1);
+ assertEquals(TABLE.filter().name("Column
Integer").greaterThan(5).getRows().size(), 3);
+ assertEquals(TABLE.filter().name("Column
Integer").greaterThan(25).getRows().size(), 2);
- assertEquals(TABLE.filter().name("Column
Double").greaterThan(10d).getRows().size(), 2);
- assertEquals(TABLE.filter().name("Column
Double").greaterThan(30d).getRows().size(), 1);
+ assertEquals(TABLE.filter().name("Column
Double").greaterThan(10d).getRows().size(), 3);
+ assertEquals(TABLE.filter().name("Column
Double").greaterThan(30d).getRows().size(), 2);
- assertEquals(TABLE.filter().name("Column
String").greaterThan("text20").getRows().size(), 2);
- assertEquals(TABLE.filter().name("Column
String").greaterThan("text30").getRows().size(), 1);
+ assertEquals(TABLE.filter().name("Column
String").greaterThan("text20").getRows().size(), 3);
+ assertEquals(TABLE.filter().name("Column
String").greaterThan("text30").getRows().size(), 2);
synchronized (TEST_DATE_FORMAT) {
- assertEquals(TABLE.filter().name("Column
Date").greaterThan(TEST_DATE_FORMAT.parse("2009-12-31")).getRows().size(), 2);
- assertEquals(TABLE.filter().name("Column
Date").greaterThan(TEST_DATE_FORMAT.parse("2011-01-01")).getRows().size(), 1);
+ assertEquals(TABLE.filter().name("Column
Date").greaterThan(TEST_DATE_FORMAT.parse("2009-12-31")).getRows().size(), 3);
+ assertEquals(TABLE.filter().name("Column
Date").greaterThan(TEST_DATE_FORMAT.parse("2011-01-01")).getRows().size(), 2);
+ }
+ }
+
+ @Test
+ public void testLessThanFilter() throws KnoxShellTableFilterException,
ParseException {
+ assertEquals(TABLE.filter().name("Column
Integer").lessThan(20).getRows().size(), 1);
+ assertEquals(TABLE.filter().name("Column
Integer").lessThan(100).getRows().size(), 3);
+
+ assertEquals(TABLE.filter().name("Column
Double").lessThan(30d).getRows().size(), 1);
+ assertEquals(TABLE.filter().name("Column
Double").lessThan(100d).getRows().size(), 3);
+
+ assertEquals(TABLE.filter().name("Column
String").lessThan("text40").getRows().size(), 1);
+ assertEquals(TABLE.filter().name("Column
String").lessThan("text70").getRows().size(), 3);
+
+ synchronized (TEST_DATE_FORMAT) {
+ assertEquals(TABLE.filter().name("Column
Date").lessThan(TEST_DATE_FORMAT.parse("2011-12-31")).getRows().size(), 1);
+ assertEquals(TABLE.filter().name("Column
Date").lessThan(TEST_DATE_FORMAT.parse("2013-01-01")).getRows().size(), 3);
+ }
+ }
+
+ @Test
+ public void testGreaterThanOrEqualToThanFilter() throws
KnoxShellTableFilterException, ParseException {
+ assertEquals(TABLE.filter().name("Column
Integer").greaterThanOrEqualTo(30).getRows().size(), 2);
+ assertEquals(TABLE.filter().name("Column
Integer").greaterThanOrEqualTo(50).getRows().size(), 1);
+
+ assertEquals(TABLE.filter().name("Column
Double").greaterThanOrEqualTo(40d).getRows().size(), 2);
+ assertEquals(TABLE.filter().name("Column
Double").greaterThanOrEqualTo(20d).getRows().size(), 3);
+
+ assertEquals(TABLE.filter().name("Column
String").greaterThanOrEqualTo("text50").getRows().size(), 2);
+ assertEquals(TABLE.filter().name("Column
String").greaterThanOrEqualTo("text30").getRows().size(), 3);
+
+ synchronized (TEST_DATE_FORMAT) {
+ assertEquals(TABLE.filter().name("Column
Date").greaterThanOrEqualTo(TEST_DATE_FORMAT.parse("2009-12-31")).getRows().size(),
3);
+ assertEquals(TABLE.filter().name("Column
Date").greaterThanOrEqualTo(TEST_DATE_FORMAT.parse("2012-01-01")).getRows().size(),
2);
+ }
+ }
+
+ @Test
+ public void testLessThanOrEqualToThanFilter() throws
KnoxShellTableFilterException, ParseException {
+ assertEquals(TABLE.filter().name("Column
Integer").lessThanOrEqualTo(30).getRows().size(), 2);
+ assertEquals(TABLE.filter().name("Column
Integer").lessThanOrEqualTo(50).getRows().size(), 3);
+
+ assertEquals(TABLE.filter().name("Column
Double").lessThanOrEqualTo(40d).getRows().size(), 2);
+ assertEquals(TABLE.filter().name("Column
Double").lessThanOrEqualTo(20d).getRows().size(), 1);
+
+ assertEquals(TABLE.filter().name("Column
String").lessThanOrEqualTo("text50").getRows().size(), 2);
+ assertEquals(TABLE.filter().name("Column
String").lessThanOrEqualTo("text30").getRows().size(), 1);
+
+ synchronized (TEST_DATE_FORMAT) {
+ assertEquals(TABLE.filter().name("Column
Date").lessThanOrEqualTo(TEST_DATE_FORMAT.parse("2012-02-01")).getRows().size(),
3);
+ assertEquals(TABLE.filter().name("Column
Date").lessThanOrEqualTo(TEST_DATE_FORMAT.parse("2010-01-01")).getRows().size(),
1);
+ }
+ }
+
+ @Test
+ public void testEqualToFilter() throws KnoxShellTableFilterException,
ParseException {
+ assertEquals(TABLE.filter().name("Column
Integer").equalTo(60).getRows().size(), 0);
+ assertEquals(TABLE.filter().name("Column
Integer").equalTo(50).getRows().size(), 1);
+
+ assertEquals(TABLE.filter().name("Column
Double").equalTo(40d).getRows().size(), 1);
+ assertEquals(TABLE.filter().name("Column
Double").equalTo(90d).getRows().size(), 0);
+
+ assertEquals(TABLE.filter().name("Column
String").equalTo("text90").getRows().size(), 0);
+ assertEquals(TABLE.filter().name("Column
String").equalTo("text30").getRows().size(), 1);
+
+ synchronized (TEST_DATE_FORMAT) {
+ assertEquals(TABLE.filter().name("Column
Date").equalTo(TEST_DATE_FORMAT.parse("2012-02-01")).getRows().size(), 1);
Review comment:
The date on line 42 is `2012-02-01` which is what I'm filtering for on line
132.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 321240)
Time Spent: 4.5h (was: 4h 20m)
> KnoxShellTable Filtering needs greaterThan and lessThan, equals Methods
> -----------------------------------------------------------------------
>
> Key: KNOX-2018
> URL: https://issues.apache.org/jira/browse/KNOX-2018
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxShell
> Reporter: Larry McCay
> Assignee: Ljmiv
> Priority: Major
> Labels: noob
> Fix For: 1.4.0
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> It would be useful to have greaterThan and lessThan filtering for
> KnoxShellTable.
> Currently we have a regex match to filter matches.
> Some easier methods for greaterThan, lessThan, equals, equalsIgnoreCare, etc
> would be very helpful as regex for those things may be possible but more
> complicated than necessary.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
