pzampino commented on code in PR #742:
URL: https://github.com/apache/knox/pull/742#discussion_r1146365404
##########
gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/AbstractHdfsHaDispatch.java:
##########
@@ -78,14 +60,35 @@ protected void executeRequest(HttpUriRequest
outboundRequest, HttpServletRequest
inboundResponse = executeOutboundRequest(outboundRequest);
writeOutboundResponse(outboundRequest, inboundRequest,
outboundResponse, inboundResponse);
} catch (StandbyException e) {
- LOG.errorReceivedFromStandbyNode(e);
- failoverRequest(outboundRequest, inboundRequest, outboundResponse,
inboundResponse, e);
+ /* if non-idempotent requests are not allowed to failover */
Review Comment:
This seems like it could be pulled out to a common method, or a
multi-Exception catch block since the handling is all exactly the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
