moresandeep commented on code in PR #742: URL: https://github.com/apache/knox/pull/742#discussion_r1146383037
########## gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/ConfigurableHADispatch.java: ########## @@ -61,18 +61,20 @@ public class ConfigurableHADispatch extends ConfigurableDispatch { protected static final HaDispatchMessages LOG = MessagesFactory.get(HaDispatchMessages.class); - private int maxFailoverAttempts = HaServiceConfigConstants.DEFAULT_MAX_FAILOVER_ATTEMPTS; + protected int maxFailoverAttempts = HaServiceConfigConstants.DEFAULT_MAX_FAILOVER_ATTEMPTS; - private int failoverSleep = HaServiceConfigConstants.DEFAULT_FAILOVER_SLEEP; + protected int failoverSleep = HaServiceConfigConstants.DEFAULT_FAILOVER_SLEEP; - private HaProvider haProvider; + protected HaProvider haProvider; private static final Map<String, String> urlToHashLookup = new HashMap<>(); private static final Map<String, String> hashToUrlLookup = new HashMap<>(); + protected static final List<String> idempotentRequests = Arrays.asList("POST", "PATCH", "CONNECT"); Review Comment: darn it, naming, i'll change it. Good Catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org