smolnar82 commented on code in PR #750:
URL: https://github.com/apache/knox/pull/750#discussion_r1176212466
##########
gateway-topology-hadoop-xml/src/main/java/org/apache/knox/gateway/topology/hadoop/xml/HadoopXmlResourceMonitor.java:
##########
@@ -97,6 +100,19 @@ private void processClouderaManagerDescriptor(String
descriptorFilePath, String
final HadoopXmlResourceParserResult result =
hadoopXmlResourceParser.parse(descriptorFilePath, topologyName);
processSharedProviders(result);
processDescriptors(result);
+ processDeleted(descriptorsDir, result.getDeletedDescriptors(), ".json");
+ processDeleted(topologiesDir, result.getDeletedDescriptors(), ".xml");
Review Comment:
As discussed offline, we may not need to remove topologies manually, because
there are supposed to be deleted by
[DescriptorsMonitor.onFileDelete](https://github.com/smolnar82/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/topology/monitor/DescriptorsMonitor.java#L67-L91).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
