smolnar82 commented on code in PR #750: URL: https://github.com/apache/knox/pull/750#discussion_r1176307405
########## gateway-topology-hadoop-xml/src/main/java/org/apache/knox/gateway/topology/hadoop/xml/HadoopXmlResourceParser.java: ########## @@ -70,6 +71,7 @@ public class HadoopXmlResourceParser implements AdvancedServiceDiscoveryConfigCh private static final String CONFIG_NAME_APPLICATION_PREFIX = "app"; private static final String CONFIG_NAME_SERVICE_URL = "url"; private static final String CONFIG_NAME_SERVICE_VERSION = "version"; + public static final String REMOVE = "remove"; Review Comment: We already have a constant for `remove` (see `CONFIG_NAME_PROVIDER_CONFIGS_PARAM_REMOVE` above). We may remove that one and use this new, more generic, contstant name. ########## gateway-topology-hadoop-xml/src/main/java/org/apache/knox/gateway/topology/hadoop/xml/HadoopXmlResourceParser.java: ########## @@ -70,6 +71,7 @@ public class HadoopXmlResourceParser implements AdvancedServiceDiscoveryConfigCh private static final String CONFIG_NAME_APPLICATION_PREFIX = "app"; private static final String CONFIG_NAME_SERVICE_URL = "url"; private static final String CONFIG_NAME_SERVICE_VERSION = "version"; + public static final String REMOVE = "remove"; Review Comment: We already have a constant for `remove` (see `CONFIG_NAME_PROVIDER_CONFIGS_PARAM_REMOVE` above). We may remove that one and use this new, more generic, constant name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
