zeroflag commented on code in PR #787:
URL: https://github.com/apache/knox/pull/787#discussion_r1342588261
##########
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java:
##########
@@ -933,6 +936,20 @@ private synchronized void internalActivateArchive(
Topology topology, File warDi
}
}
+ private void processApplicationPathAliases(File warDir, Topology topology) {
+ final Map<String, Collection<String>> applicationPathAliases =
config.getApplicationPathAliases();
+ if (!applicationPathAliases.isEmpty()) {
Review Comment:
Then at least let's make it a null check instead of `isEmpty`. That would
protect us against NPEs, while this doesn't defend against anything.
Personally if `config.getApplicationPathAliases()` is guaranteed to be not
null, I wouldn't even use a null check, but if I had to decide between those 2
then I would choose a null check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
