pzampino commented on code in PR #787:
URL: https://github.com/apache/knox/pull/787#discussion_r1347817273
##########
gateway-release/home/conf/gateway-site.xml:
##########
@@ -134,6 +134,13 @@ limitations under the License.
<description>A duration (in seconds) beyond a token’s expiration to
wait before evicting its state. This configuration only applies when
server-managed token state is enabled either in gateway-site or at the topology
level.</description>
</property>
+ <!-- @since 2.1.0 application path aliases -->
+ <property>
Review Comment:
I'm wondering if it's possible/beneficial to support this at the topology
level.
##########
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java:
##########
@@ -1489,4 +1489,20 @@ public boolean isAsyncSupported() {
return getBoolean(GATEWAY_SERVLET_ASYNC_SUPPORTED,
GATEWAY_SERVLET_ASYNC_SUPPORTED_DEFAULT);
}
+ @Override
+ public Map<String, Collection<String>> getApplicationPathAliases() {
+ return getPathAliase(".application");
Review Comment:
typo: see comment on method itself.
##########
knox-token-management-ui/token-management/app/token.management.component.ts:
##########
@@ -30,7 +30,9 @@ import {MatSort} from '@angular/material/sort';
export class TokenManagementComponent implements OnInit {
- tokenGenerationPageURL = window.location.pathname.replace(new
RegExp('token-management/.*'), 'token-generation/index.html');
+ pathParts = window.location.pathname.split('/');
Review Comment:
These lines smell like a utility method to me.
##########
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java:
##########
@@ -1489,4 +1489,20 @@ public boolean isAsyncSupported() {
return getBoolean(GATEWAY_SERVLET_ASYNC_SUPPORTED,
GATEWAY_SERVLET_ASYNC_SUPPORTED_DEFAULT);
}
+ @Override
+ public Map<String, Collection<String>> getApplicationPathAliases() {
+ return getPathAliase(".application");
+ }
+
+ private Map<String, Collection<String>> getPathAliase(String qualifier) {
Review Comment:
typo: getPathAliase --> getPathAliases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
