kardolus commented on PR #914: URL: https://github.com/apache/knox/pull/914#issuecomment-2152623061
@moresandeep @pzampino Now that we made the pattern configurable, I am wondering if it should be an array. I mean, now that you can create patterns for [IP addresses](https://github.com/kardolus/knox/blob/e11912a281eb33f497329eaf397a4419216ed751/gateway-server/src/test/java/org/apache/knox/gateway/GatewayServletTest.java#L44), [email addresses](https://github.com/kardolus/knox/blob/e11912a281eb33f497329eaf397a4419216ed751/gateway-server/src/test/java/org/apache/knox/gateway/GatewayServletTest.java#L45), and [credit cards](https://github.com/kardolus/knox/blob/e11912a281eb33f497329eaf397a4419216ed751/gateway-server/src/test/java/org/apache/knox/gateway/GatewayServletTest.java#L46), the question arises: why not just hide all three? But on the other hand, this does feel a bit over-engineered in my opinion. Also, we could do this in a later iteration. Do y'all have an opinion on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
