pzampino commented on PR #914: URL: https://github.com/apache/knox/pull/914#issuecomment-2168011045
> @pzampino @moresandeep I implemented the `SanitizedException`. It makes the code a lot cleaner. I am not happy with the fact though that an `IOException` or a `RuntimeException` can be converted to a `ServletException` (a `SanitizedException` `IS-A` `ServletException`) through the sanitization flow. > > But maybe I am overthinking things and overengineering. What do y'all think? Is it fine? Unless the servlet engine treats them differently in some meaningful way, I think it's ok, so long as the exception does not get lost entirely, which in this case, it does not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
