[ 
https://issues.apache.org/jira/browse/KNOX-3068?focusedWorklogId=937046&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-937046
 ]

ASF GitHub Bot logged work on KNOX-3068:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Oct/24 18:35
            Start Date: 08/Oct/24 18:35
    Worklog Time Spent: 10m 
      Work Description: lmccay commented on code in PR #937:
URL: https://github.com/apache/knox/pull/937#discussion_r1792335405


##########
gateway-service-definitions/src/main/resources/services/iceberg-rest/0.0.1/rewrite.xml:
##########
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+-->
+<rules>
+    <rule dir="IN" name="ICEBERG-REST/iceberg-rest/inbound" 
pattern="*://*:*/**/iceberg-rest/{path=**}?{**}">

Review Comment:
   We need REST in the name since it is a specific API. ICEBERG-REST-API is 
fine if we are using that convention.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 937046)
    Time Spent: 0.5h  (was: 20m)

> Iceberg REST Catalog service definition
> ---------------------------------------
>
>                 Key: KNOX-3068
>                 URL: https://issues.apache.org/jira/browse/KNOX-3068
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Server
>    Affects Versions: 2.1.0
>            Reporter: Philip Zampino
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Need service definition and rewrite rules for Iceberg REST Catalog service.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to