[
https://issues.apache.org/jira/browse/KNOX-3068?focusedWorklogId=937054&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-937054
]
ASF GitHub Bot logged work on KNOX-3068:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/24 19:27
Start Date: 08/Oct/24 19:27
Worklog Time Spent: 10m
Work Description: pzampino commented on code in PR #937:
URL: https://github.com/apache/knox/pull/937#discussion_r1792399333
##########
gateway-service-definitions/src/main/resources/services/iceberg-rest/0.0.1/rewrite.xml:
##########
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<rules>
+ <rule dir="IN" name="ICEBERG-REST/iceberg-rest/inbound"
pattern="*://*:*/**/iceberg-rest/{path=**}?{**}">
Review Comment:
Right, and I'm not convinced there is really a convention to append -api as
I review the existing service defs. I propose leaving it as it is, but I'm open
to different opinions.
Issue Time Tracking
-------------------
Worklog Id: (was: 937054)
Time Spent: 40m (was: 0.5h)
> Iceberg REST Catalog service definition
> ---------------------------------------
>
> Key: KNOX-3068
> URL: https://issues.apache.org/jira/browse/KNOX-3068
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 2.1.0
> Reporter: Philip Zampino
> Assignee: Philip Zampino
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Need service definition and rewrite rules for Iceberg REST Catalog service.
> This API is a standard from the Iceberg community which provides a REST API
> access to the metastore, associated metadata and cloud storage.
> This service definition should be portable to any implementation of the API
> with appropriate trusted proxy support as required for Knox based proxying.
> See
> https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml
> for the open api description.
> In conjunction with:
> https://issues.apache.org/jira/browse/KNOX-3016
> https://issues.apache.org/jira/browse/KNOX-3028
> We can support the CLIENT_ID and CLIENT_SECRET issuance, the exchange of
> those for a JWT token to be used as a bearer token and with this patch the
> dispatch to a knox trusing REST Catalog implementation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
