[
https://issues.apache.org/jira/browse/KNOX-3065?focusedWorklogId=942747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-942747
]
ASF GitHub Bot logged work on KNOX-3065:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/24 10:01
Start Date: 08/Nov/24 10:01
Worklog Time Spent: 10m
Work Description: hanicz commented on code in PR #947:
URL: https://github.com/apache/knox/pull/947#discussion_r1834061825
##########
gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/GatewayDispatchFilter.java:
##########
@@ -217,15 +218,28 @@ public void doMethod(Dispatch dispatch,
HttpServletRequest request, HttpServletR
}
}
- private <T> T newInstanceFromName(String dispatchImpl) throws
ServletException {
+ private <T> T newInstanceFromName(String dispatchImpl, FilterConfig
filterConfig) throws ServletException {
try {
Class<T> clazz = loadClass(dispatchImpl);
Review Comment:
I don't think it can ever return null.
Issue Time Tracking
-------------------
Worklog Id: (was: 942747)
Time Spent: 2h 10m (was: 2h)
> Support Server Sent Events (SSE) in Knox
> ----------------------------------------
>
> Key: KNOX-3065
> URL: https://issues.apache.org/jira/browse/KNOX-3065
> Project: Apache Knox
> Issue Type: New Feature
> Components: Server
> Affects Versions: 2.1.0
> Reporter: Tamás Hanicz
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently Knox is not working with SSE. In case of SSE the response header
> contains Content-Type = text/event-stream, in which case the server will send
> messages terminated by \n\n. Knox should send these messages to the client as
> they arrive. Currently Knox collects them all, and once the server closes the
> connection sends all of them concatenated to each other to the client.
> Requirement:
> * Full support in Knox for Server Sent Events.
> Definition of done:
> * Clients can connect to SSE endpoints in the backend via Knox.
> * Server Sent Events
> ([https://html.spec.whatwg.org/multipage/server-sent-events.html#server-sent-events])
> are forwarded by Knox from the server to the client as soon as they are
> received.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
